Change Sync Config Duration Type

[kyleishie]

updates sync config to use protobuf duration type to allow for friendlier API.

Summary by CodeRabbit

• Refactor
  • Improved the configuration's time duration handling for synchronization settings.
  • Updated timeout handling in various parts of the codebase for better consistency and reliability.

[coderabbitai]

Walkthrough

The recent changes involve transitioning key components to utilize durationpb.Duration for managing timeouts, enhancing consistency and efficiency across the system. This update ensures robust timeout handling and aligns the codebase with modern practices for duration management.

Changes

File	Change Summary
internal/pkg/config/sync.go internal/plugins/ostree/api.go internal/plugins/ostree/pkg/ostreerepository/api.go pkg/plugins/ostree/api/v1/api.go	Updated timeout handling to use durationpb.Duration for improved timeout management and consistency. Modifications include validating and extracting seconds from durations, enhancing timeout configuration across related functions.

🐇✨

Bytes and bits in a whimsical dance,
durationpb.Duration brings a new chance.
Timeout management with precision and care,
The rabbit's touch, light as air.

Code sings a tune of efficiency and light,
In the glow of the screen, all is bright.
🌟🐰💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9e175d7 and 9830cb6.

Files ignored due to path filters (2)

• charts/beskar-ostree/values.yaml is excluded by: !**/*.yaml
• internal/plugins/ostree/pkg/config/default/beskar-ostree.yaml is excluded by: !**/*.yaml

Files selected for processing (1)

• internal/pkg/config/sync.go (1 hunks)

Additional comments: 2

internal/pkg/config/sync.go (2)

• 7-9: The import of the time package is still present but appears unused in the provided code changes. Verify if it's still needed elsewhere in the file or consider removing it to clean up unused imports.
• 3-33: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [30-36]

The GetMaxWorkerCount method logic is sound and aligns with best practices by using a pointer receiver. No issues found.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9830cb6 and bd1fc71.

Files selected for processing (4)

• internal/pkg/config/sync.go (1 hunks)
• internal/plugins/ostree/api.go (1 hunks)
• internal/plugins/ostree/pkg/ostreerepository/api.go (1 hunks)
• pkg/plugins/ostree/api/v1/api.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• internal/pkg/config/sync.go

Additional comments: 3

internal/plugins/ostree/api.go (1)

• 75-76: Ensure that the default timeout value p.beskarOSTreeConfig.Sync.Timeout is always valid and non-nil to prevent potential runtime panics or logic errors.

pkg/plugins/ostree/api/v1/api.go (1)

• 68-69: The change to use durationpb.Duration for the Timeout field is consistent with the PR objectives and enhances compatibility with protobuf systems. Ensure all usages of Timeout are updated to handle the durationpb.Duration type correctly.

internal/plugins/ostree/pkg/ostreerepository/api.go (1)

• 276-276: The use of .AsDuration() correctly converts durationpb.Duration to time.Duration for the context.WithTimeout call. Ensure that properties.Timeout is always valid when this method is called to prevent unexpected behavior.