Fixes issue with insecure storage backends

[kyleishie]

makes sync timeout configurable for ostree plugin
makes sync worker count configurable for ostree plugin
minor logging updates
fixes issue in which beskar plugins were unable to communicate with insecure storage backends

Summary by CodeRabbit

• New Features

  • Introduced configuration enhancements for synchronization operations, including timeout settings and worker count adjustments.
  • Improved error messaging for image pushing processes, providing clearer context on failures.

• Bug Fixes

  • Adjusted network dialing behavior for specific addresses to correctly handle refused connections.

• Refactor

  • Updated various components to utilize dynamic timeout values and worker counts from configuration, replacing hardcoded values.
  • Enhanced logging details for repository pushing operations.

[coderabbitai]

Walkthrough

The recent updates introduce enhanced configuration and dynamic handling in synchronization and network operations across various components. Key improvements include configurable timeouts, worker count adjustments for operations, and more descriptive error handling in image pushing. A notable change is the specific handling of connections to a designated address, enhancing the system's flexibility and error reporting.

Changes

Files	Change Summary
.../pkg/config/sync.go	Introduced SyncConfig with timeout and max worker count, including defaults and retrieval methods.
.../pluginsrv/service.go	Added conditional check for beskarAddr handling in getBeskarTransport.
.../repository/handler.go, .../ostree/plugin.go	Added SyncConfig to structures for enhanced sync configuration.
.../ostree/api.go, .../ostree/pkg/ostreerepository/api.go, .../plugins/ostree/api/v1/api.go	Adjusted timeout handling in sync operations.
.../ostree/pkg/config/beskar-ostree.go, .../ostree/pkg/ostreerepository/local.go	Included SyncConfig for dynamic worker count and timeout configurations.
pkg/oras/push.go	Updated error messages in Push for clarity.
pkg/orasostree/repo.go	Modified logging to ensure reference is logged as a string.

🐇✨
In the code, where bytes dance and play,
A rabbit hopped, making changes sway.
With sync and time, it twirled around,
Crafting code, where magic's found.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 98866e2 and 017e35f.

Files ignored due to path filters (1)

• internal/plugins/ostree/pkg/config/default/beskar-ostree.yaml is excluded by: !**/*.yaml

Files selected for processing (11)

• internal/pkg/config/sync.go (1 hunks)
• internal/pkg/pluginsrv/service.go (1 hunks)
• internal/pkg/repository/handler.go (2 hunks)
• internal/plugins/ostree/api.go (1 hunks)
• internal/plugins/ostree/pkg/config/beskar-ostree.go (1 hunks)
• internal/plugins/ostree/pkg/ostreerepository/api.go (2 hunks)
• internal/plugins/ostree/pkg/ostreerepository/local.go (1 hunks)
• internal/plugins/ostree/plugin.go (2 hunks)
• pkg/oras/push.go (2 hunks)
• pkg/orasostree/repo.go (1 hunks)
• pkg/plugins/ostree/api/v1/api.go (2 hunks)

Additional comments: 2

internal/plugins/ostree/pkg/ostreerepository/api.go (2)

• 276-276: The dynamic timeout value obtained from properties.Timeout is correctly implemented, ensuring that the synchronization process is more configurable.
• 8-13: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-275]

Overall, the file adheres to good practices in error handling, logging, and structuring of functions. No additional issues detected outside the scope of the SyncRepository function changes.

Also applies to: 277-366