TRR tests in main module #172

guillaumegrolleron · 2025-01-23T19:57:53Z

This PR change the location of the TRR test suite into the main module with a dedicated submodule trr_test_suite.

I change the PyQt dependencies to the version 6 too.

guillaumegrolleron · 2025-01-23T19:59:42Z

Sorry my branch looks strange with to much commits... I will fix this

codecov · 2025-01-23T20:08:58Z

Codecov Report

Attention: Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.

Project coverage is 48.77%. Comparing base (bac8691) to head (880b77f).

Files with missing lines	Patch %	Lines
src/nectarchain/trr_test_suite/gui.py	0.00%	15 Missing ⚠️
src/nectarchain/trr_test_suite/tools_components.py	0.00%	8 Missing ⚠️
src/nectarchain/trr_test_suite/linearity.py	0.00%	3 Missing ⚠️
...chain/trr_test_suite/pix_couple_tim_uncertainty.py	0.00%	3 Missing ⚠️
src/nectarchain/trr_test_suite/__init__.py	0.00%	2 Missing ⚠️
src/nectarchain/trr_test_suite/deadtime.py	0.00%	2 Missing ⚠️
src/nectarchain/trr_test_suite/pedestal.py	0.00%	2 Missing ⚠️
.../nectarchain/trr_test_suite/pix_tim_uncertainty.py	0.00%	2 Missing ⚠️
src/nectarchain/trr_test_suite/trigger_timing.py	0.00%	2 Missing ⚠️
src/nectarchain/trr_test_suite/utils.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #172       +/-   ##
===========================================
- Coverage   63.24%   48.77%   -14.48%     
===========================================
  Files          64       74       +10     
  Lines        4734     6139     +1405     
===========================================
  Hits         2994     2994               
- Misses       1740     3145     +1405

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ds to find computed calibration quatities

…anted one -update pp and n values to last studies -display wfs -> mean instead of sum -Agg backend is not forced in Pstat calibnration

exluse user_scripts to pytest

improvement split_run method

…nectarcam

gange pyq5 to pyqt6

This reverts commit d07747a, reversing changes made to 2dadf7e.

guillaumegrolleron · 2025-01-23T20:43:21Z

Reopen new PR

guillaume.grolleron added 28 commits January 23, 2025 21:18

add arg to load only wfs and do not extract charges

99c7d3c

cleaner way to treat containers inside makers

ab1ee04

new methods to find computed calibration quatities

08ffabe

ds to find computed calibration quatities

update to support new version of EvB v6

7fd2fe8

-bug fix SPE combined : method use to update parameters was not the w…

20504b9

…anted one -update pp and n values to last studies -display wfs -> mean instead of sum -Agg backend is not forced in Pstat calibnration

add find photostat result method

2fa7e22

user scripts

95e2c96

fix import errors in TRR

6f526b0

exluse user_scripts to pytest

bugfix : logger

efd99ce

improvement split_run method

static method decorator were missing

6de72ac

bugfix with new version of LIghtNectarCAMEventSource from ctapipe_io_…

4386513

…nectarcam

Unit test for WaveformsNectarCAMCalibrationTool

9a35828

Unit test for the ChargesNectarCAMCalibrationTool

e11c1fd

formatting

d684636

fix test core makers

9826442

formatting

42886bf

formatting

1f46a44

flake8 formatting

9f5a9d5

refactoring folling pep8

37817de

dqm flake8

4463bfa

refactoring containers

399661f

fix bug formatting

3ca2069

shitty python formatting

3dc5918

test bugfix

498d06d

pedestal maker : implementation of I/O with containers

ed5f3ef

bugfix in toml file introduced in previous commits

e4ec62a

unit test for component core

1f57b2d

change filename

d3b7f2e

guillaume.grolleron added 27 commits January 23, 2025 21:18

fix pyqtgraph pip installation instead of conda-forge

dfc1cbc

pyqt6 to pyqt5

600d2b3

fix pyqt

6e4ef18

fix pyqtgraph

0e2bbf8

fix pip

ee536ad

fix pyqt

9c5b6d9

add pip dependencies to pyproject.toml

ed728d5

pyqt6 to pyqt5

4aff81b

pin version of pyqtgraph

96eab92

typo

b4038c9

same in toml

e2856c0

idk

ce71627

typo

07b0cea

fix

884912a

test fix

00c6c4e

pyside6 vs pyqt

990f00e

tml

5ed7e5a

last try

30f966e

last

c3c0c27

move TRR test suite into nectarchain

7a38e18

fix imports

3205bbb

fix imports and format

5d48c37

gange pyq5 to pyqt6

add h5py depencie

4ac60aa

add lmfit to pyproject.toml

2187184

fix docstring

05fefc6

fix sphinx issue with PyQt6 subclass imports

cc72da0

Revert "Merge branch 'main' into TTR_tests"

880b77f

This reverts commit d07747a, reversing changes made to 2dadf7e.

guillaumegrolleron force-pushed the TTR_tests branch from 329d90d to 880b77f Compare January 23, 2025 20:23

guillaumegrolleron closed this Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRR tests in main module #172

TRR tests in main module #172

guillaumegrolleron commented Jan 23, 2025

guillaumegrolleron commented Jan 23, 2025

codecov bot commented Jan 23, 2025 •

edited

Loading

guillaumegrolleron commented Jan 23, 2025

TRR tests in main module #172

TRR tests in main module #172

Conversation

guillaumegrolleron commented Jan 23, 2025

guillaumegrolleron commented Jan 23, 2025

codecov bot commented Jan 23, 2025 • edited Loading

Codecov Report

guillaumegrolleron commented Jan 23, 2025

codecov bot commented Jan 23, 2025 •

edited

Loading