Unit test (part 2) #168
Merged
Unit test (part 2) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 23, 2024 15:55
ds to find computed calibration quatities
…anted one -update pp and n values to last studies -display wfs -> mean instead of sum -Agg backend is not forced in Pstat calibnration
…ain into dev_test_doc
exluse user_scripts to pytest
improvement split_run method
added 16 commits
January 21, 2025 23:26
|
Hi @jlenain It was a mess but I actually found a solution :
I'll fix in a upcoming PR the |
|
OK, thanks a lot, @guillaumegrolleron , what a journey! I'll have a look at the rest of the changes, but a first pass already looked good to me. Final review coming ASAP. |
jlenain
reviewed
Jan 22, 2025
jlenain
reviewed
Jan 22, 2025
jlenain
reviewed
Jan 22, 2025
src/nectarchain/makers/component/tests/test_flatfield_spe_component.py
Outdated
Show resolved
Hide resolved
jlenain
reviewed
Jan 22, 2025
src/nectarchain/user_scripts/dmousadi/TRR_scripts/src/tools_components.py
Outdated
Show resolved
Hide resolved
jlenain
reviewed
Jan 22, 2025
src/nectarchain/user_scripts/dmousadi/TRR_scripts/src/pedestal.py
Outdated
Show resolved
Hide resolved
jlenain
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Many many thanks, @guillaumegrolleron ! Tested, working & approved !
jlenain
added a commit
to ArmelleJB/nectarchain
that referenced
this pull request
Jan 22, 2025
jlenain
added a commit
that referenced
this pull request
Jan 30, 2025
* Add a new flat field container * Add all necessary fields in FlatFieldContainer * Add new component for computation of flat field coefficient * Update flat field tools * New script for flat field tests * Add flatfieldContainer and preFlatFieldComponent import * implement of comments and cleaning * example script to run the flat field tool * Fix conflicts following merge of PR #163 * Renamed script to avoid any conflict with pytest * implement changes to use the same components for the 2 passes * example of how to run the flat field tool twice, including functions to calculate gain, hi/lo ratio and identify bad pixels * Resolve conflicts with `main` following merge of PR #168 --------- Co-authored-by: Jean-Philippe Lenain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the follow-up of the PR #163.
Unit tests are implemented for all the
componentmodule and SPE calibrationmakers