Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic documentation #141

Merged
merged 31 commits into from
Jul 31, 2024
Merged

Automatic documentation #141

merged 31 commits into from
Jul 31, 2024

Conversation

jlenain
Copy link
Collaborator

@jlenain jlenain commented Jul 31, 2024

This PR extends #130 by including a full automatic documentation of the whole API, just by using the recursive option of sphinx.ext.autosummary.

It also fixes quite a few typos in Docstrings, to comply with the reStructuredText format.

@jlenain jlenain changed the title Automatic docuemntation Automatic documentation Jul 31, 2024
@jlenain jlenain self-assigned this Jul 31, 2024
@jlenain jlenain requested a review from vmarandon July 31, 2024 13:36
@jlenain
Copy link
Collaborator Author

jlenain commented Jul 31, 2024

The docs job in CI fails, because of a misformatted docstring in ctapipe_io_nectarcam. As soon as we also document the plugin, this failure should go away, by mapping the ctapipe_io_nectarcam documentation through an intersphinx-mapping instruction.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.48%. Comparing base (b306f30) to head (54c605e).
Report is 16 commits behind head on main.

Files Patch % Lines
src/nectarchain/makers/core.py 73.33% 4 Missing ⚠️
.../nectarchain/makers/component/spe/spe_algorithm.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   40.76%   42.48%   +1.71%     
==========================================
  Files          65       65              
  Lines        4452     4566     +114     
==========================================
+ Hits         1815     1940     +125     
+ Misses       2637     2626      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jlenain added a commit to jlenain/ctapipe_io_nectarcam that referenced this pull request Jul 31, 2024
jlenain and others added 5 commits July 31, 2024 22:17
* Add a Tool that can split data based on delimiter trigger

* Improve documentation

* A bit of cleaning

* Refactored split_run, some coding style

---------

Co-authored-by: Jean-Philippe Lenain <[email protected]>
@jlenain jlenain merged commit e4bef46 into cta-observatory:main Jul 31, 2024
10 of 11 checks passed
@jlenain jlenain deleted the docs branch July 31, 2024 21:11
@jlenain jlenain mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants