Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed studyroomMigration #462

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Fixed studyroomMigration #462

merged 6 commits into from
Nov 21, 2024

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Nov 13, 2024

This PR fixes a recent migration which had a mistake in it. dude to manual changes to the schema.rb it was hard to noticed and went to production

@lodewiges lodewiges marked this pull request as draft November 13, 2024 18:47
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (fbf1070) to head (c7ec23f).
Report is 2 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #462   +/-   ##
========================================
  Coverage    99.92%   99.92%           
========================================
  Files          207      207           
  Lines         2733     2733           
========================================
  Hits          2731     2731           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lodewiges lodewiges marked this pull request as ready for review November 13, 2024 19:37
Copy link
Contributor

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested locally

@lodewiges lodewiges added this pull request to the merge queue Nov 21, 2024
Merged via the queue into staging with commit 4003999 Nov 21, 2024
5 checks passed
@lodewiges lodewiges deleted the fix/studyroomMigration branch November 21, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants