This repository has been archived by the owner on Dec 31, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by resolving this in the exporter, we can avoid a race condtion where
sometimes
relatedModule
had not been indicated when it should have been.an example of what this fixes can be seen in dojo/_base/Color where the annotated type of a parameter is the return value of the same module. it's roughly equivalent to what's outlined in the code below
when the type annotation for
start
andend
are processed, the parser has not markedColor
with arelatedModule
and so the properties ofColor
are iterated to produce an "additional description" - this is wrong.this effectively includes #81 so i'll close that in favor of this