-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #42
Draft
csmir
wants to merge
41
commits into
master
Choose a base branch
from
v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will summarize all the changes between v2 and v3, serving as a progression log for the major update.
What's new?
.NET 8
.TypeReader(T)
has been renamed toTypeConverter(T)
TypeConverter(T)
is now asynchronous.EnumTypeConverter
no longer supports local implementations, automatically resolvingEnum
conversion.PreconditionAttribute
is now asynchronous.ExecuteAsync
method has been renamed toTryExecuteAsync
.TryExecuteAsync
now has a taskless overload calledTryExecute
object[]
and object-form parsing.Parser(T)
has been added as a replacement toIParser
.StringParser
has been added as a default parser implementation.ModuleBase
now supportBefore/AfterExecuteAsync
for module-level logic.ModuleBase
now handle unknown command results usingHandleUnknownInvocationResult
.ModuleBase
now hasIServiceProvider
as a prepopulated argument.ICommandContext
no longer contains query arguments.ICommandContext
implementations are now dis-advised compared to implementations ofCommandContext
CommandContext
took over logging functionality, with virtual methods to override for log resolvers.CommandContext
now carries fallback metadata, returning the first failed result when all results fail.ResultResolver
has been added to resolve command results.ICommandResult
and 5 implementations have been added to report and track command succession rate.SearchResult
reports search failure, or holds the data of successful searches.MatchResult
reports match failure, or holds match succession data.CheckResult
returnsPreconditionAttribute.EvaluateAsync(...)
succession data.ConvertResult
returnsTypeConverter(T).EvaluateAsync(...)
succession data.RunResult
returns invocation failure or success.await
TryExecuteAsync
overloads in all cases.CommandConfiguration
has been renamed and received an improved API.AsyncApproach
.CommandManager
has a new constructor.ServiceHelpers
has new signatures for creation methods.ThrowHelpers
has been introduced.Command/GroupAttribute
to support CLS compliant alias implementation.