Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queries for counts in course data export #501

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

smartspot2
Copy link
Member

Prior, due to traversals through many-to-many and many-to-one field relations, the counts for the number of students/mentors/sections were messed up. This has now been fixed by ensuring that the counts are for distinct objects.

The Django admin console section count has also been fixed to actually look at the number of sections, since now mentors can be associated with no section.

@smartspot2 smartspot2 added bug Something isn't working python Pull requests that update Python code sev2 Urgent severity - Production system down labels Oct 21, 2024
@smartspot2 smartspot2 self-assigned this Oct 21, 2024
Copy link

cypress bot commented Oct 22, 2024

csm_web    Run #384

Run Properties:  status check passed Passed #384  •  git commit 31c3e1048d: Fix queries for counts in course data export (#501)
Project csm_web
Branch Review master
Run status status check passed Passed #384
Run duration 01m 58s
Commit git commit 31c3e1048d: Fix queries for counts in course data export (#501)
Committer Alec Li
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@faithdennis faithdennis reopened this Nov 19, 2024
@smartspot2 smartspot2 merged commit 31c3e10 into master Dec 6, 2024
28 checks passed
@smartspot2 smartspot2 deleted the fix/export-course-data branch December 6, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code sev2 Urgent severity - Production system down
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants