-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Python 3.12 and Django 5 #477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartspot2
added
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
labels
Jul 13, 2024
csm_web Run #392
Run Properties:
|
Project |
csm_web
|
Branch Review |
master
|
Run status |
Passed #392
|
Run duration | 02m 12s |
Commit |
57cc852899: Upgrade to Python 3.12 and Django 5 (#477)
|
Committer | Alec Li |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
84
|
View all changes introduced in this branch ↗︎ |
smartspot2
force-pushed
the
deps/python-django-upgrade
branch
from
July 23, 2024 02:52
51a226d
to
0f708bd
Compare
smartspot2
force-pushed
the
deps/python-django-upgrade
branch
2 times, most recently
from
September 11, 2024 05:14
d3fc617
to
9b44404
Compare
smartspot2
force-pushed
the
deps/python-django-upgrade
branch
from
December 5, 2024 02:00
9b44404
to
af03dca
Compare
smartspot2
force-pushed
the
deps/python-django-upgrade
branch
from
December 6, 2024 09:22
af03dca
to
04e4db4
Compare
edwardneo
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with current scheduler data populated and works fine. Make sure to check docker containers on Heroku are updated properly. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #453
With the release of Django 5.0, Python 3.9 is no longer supported. Python 3.9 is also incredibly old at this point, so updating to a more recent version can be beneficial for the extra features and fixes.
This PR upgrades dependencies to support Django 5 and Python 3.12.
The most notable changes are:
DEFAULT_FILE_STORAGE
andSTATICFILES_STORAGE
options, adding a newSTORAGES
option instead. The existing settings have been updated to use this new setting.GET
request, and the ability to do so is removed in Django 5.0; this means that several places need to be adjusted to usePOST
requests instead. In particular:POST
request (following redirects)