Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typescript and eslint issues #446

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix various typescript and eslint issues #446

merged 1 commit into from
Dec 19, 2023

Conversation

smartspot2
Copy link
Member

This PR contains a few fixes to typescript code:

  • The ROLES object was unconventionally put in the section/Section.tsx file, when it should be an enum in utils/types.tsx
  • Fixed ESLint warnings about unused variables; added specification to ignore unused variables if they're prefixed by _
  • Added automatic import sorting for typescript files through eslint-plugin-import; this plugin also adds several checks to import statements
    • Fixed all import sorting in existing files. Prior, there were comments marking groups of images/styles, but since it is now automated, this is no longer needed. Convention-wise, new lines should still be put between groups, but this isn't strictly enforced).

@smartspot2 smartspot2 added the enhancement New feature or request label Oct 9, 2023
@smartspot2 smartspot2 self-assigned this Oct 9, 2023
@cypress
Copy link

cypress bot commented Oct 9, 2023

Passing run #267 ↗︎

0 78 0 0 Flakiness 0

Details:

Fix various typescript and eslint issues
Project: csm_web Commit: dfbb066156
Status: Passed Duration: 01:59 💡
Started: Nov 23, 2023 8:12 AM Ended: Nov 23, 2023 8:14 AM

Review all test suite changes for PR #446 ↗︎

@smartspot2 smartspot2 force-pushed the fix/ts-fixes branch 4 times, most recently from a053b07 to d4174e6 Compare October 9, 2023 09:44
ericyche
ericyche previously approved these changes Oct 10, 2023
Copy link
Contributor

@ericyche ericyche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the big refactors - works on my end and doesn't break dev + commits

@smartspot2 smartspot2 merged commit cd00cca into master Dec 19, 2023
14 checks passed
@smartspot2 smartspot2 deleted the fix/ts-fixes branch December 19, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants