187434149 flow to create user #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynthia-lixinyi
suggested changes
Apr 23, 2024
armandofox
reviewed
Apr 24, 2024
|
|
||
| # Relationship with LmsCredential | ||
| # Associasions |
armandofox
reviewed
Apr 24, 2024
| has_many :lms_credentials, dependent: :destroy | ||
| has_many :user_to_courses |
There was a problem hiding this comment.
this is a strange variable/class name, and isn't plural (which i'd expect for has_many). do you mean something like course_specific_users? it's worth taking time to think carefully about names, as once they are committed you're generally stuck with them
armandofox
reviewed
Apr 24, 2024
| it 'creates the user successfully' do | ||
| post :create, params: { email: '[email protected]' } | ||
|
|
||
| expect(response).to have_http_status(:created) |
There was a problem hiding this comment.
this is nitpicking but: technically you should proabbly put the post in a before :each block and have the 3 expectations be separate specs, since each spec is supposed to test only 1 behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Info
Changes
Explain your changes here (in such a way that you would understand why you made them a year from now).
I set up the create user flow along with rspec test
Testing
Explain how you tested your changes. If testing is not necessary, explain why.
Documentation
Does this PR require documentation. If so, explain where it can be found.
Checklist