-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add]: set up flow to add lms to course #41
Conversation
…flextensions into 187434223-set-up-flow-to-add-lms-to-course
…434223-set-up-flow-to-add-lms-to-course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#39 also has these changes. It would be great if you could remove this pr's code from the other one and resolve the comments I left on that one :)
Hi Connor, thanks for your comments! I've already made changes based on your comments on #39. Sorry for the inconvenience caused by the huge pr. Please let me know if I should make further modification on this feature branch, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally OK, made a couple of minor comments, will leave final merge authority within the team since this is the golden repo, de facto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, but overall looks good.
…434223-set-up-flow-to-add-lms-to-course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
General Info
Changes
Implement the
POST api/v1/courses/{course_id}/lms
, which creates one record in thecourse_to_lms
table.Testing
course_id
andlms_id
are invalid;external_course_id
is missing.course
andlms
exits before.course_to_lms
table.Documentation
The related tables in this implementation part in our E-R diagram are shown below.
Checklist