-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcement recommendations #52
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
-- +micrate Up | ||
CREATE TABLE recommendations ( | ||
id BIGSERIAL PRIMARY KEY, | ||
announcement_id INTEGER NOT NULL, | ||
recommended_id INTEGER NOT NULL, | ||
created_at TIMESTAMP, | ||
updated_at TIMESTAMP | ||
); | ||
|
||
-- +micrate Down | ||
DROP TABLE IF EXISTS recommendations; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
require "granite_orm/adapter/pg" | ||
|
||
class Recommendation < Granite::ORM::Base | ||
adapter pg | ||
|
||
belongs_to :announcement | ||
|
||
field announcement_id : Int32 | ||
field recommended_id : Int32 | ||
timestamps | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
require "recommender" | ||
require "sidekiq" | ||
require "../models/announcement" | ||
require "../models/recommendation" | ||
|
||
module Workers | ||
class Recommender | ||
include Sidekiq::Worker | ||
|
||
def perform | ||
clear_recommendations | ||
announcements = Announcement.all | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sooner or later this will make memory overflow... I'm not an expert in Recommender, but we need to find a way to do this without full table load. |
||
preprocessed_announcements = announcements.map { |a| "#{a.title} #{a.description}" } | ||
recommender = ::Recommender::ContentBased.new(preprocessed_announcements) | ||
|
||
signal = Channel(Nil).new | ||
|
||
preprocessed_announcements.each_with_index do |_, i| | ||
ids = recommender.similar_to(i).first(3) | ||
ids.each do |j| | ||
data = { | ||
:announcement_id => announcements[i].id, | ||
:recommended_id => announcements[j].id, | ||
} | ||
recommendation = Recommendation.new(data) | ||
spawn do | ||
recommendation.save | ||
signal.send nil | ||
end | ||
end | ||
end | ||
|
||
preprocessed_announcements.size.times { signal.receive } | ||
end | ||
|
||
private def clear_recommendations | ||
Recommendation.clear | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to remove those unneeded methods from
Announcement
model, adjust controller and specs.