Add Lint/UnusedTypeOrConstant
#537
Conversation
| incr_stack do | ||
| node.obj.try &.accept(self) |
There was a problem hiding this comment.
Needed to change this as otherwise a top-level MyClass.run would be flagged. It does mean things like "hello".to_s will no longer be flagged as unused
|
|
nobodywasishere
changed the title
Lint/UnusedPathGenericOrUnionLint/UnusedTypeOrConstant
| def hello | ||
| Float64 | ||
| # ^^^^^^^ error: Path or generic type is not used | ||
| 0.1 | ||
| end | ||
|
|
||
| fun fun_name : Int32 | ||
| Int32 | ||
| # ^^^^^ error: Path or generic type is not used | ||
| 1234 | ||
| end | ||
|
|
||
| class MyClass | ||
| MyModule | ||
| # ^^^^^^^^ error: Path or generic type is not used | ||
| end |
There was a problem hiding this comment.
these are not "top level" as mentioned in the spec name. Can we move it to a separate testcase?
| it "passes if paths and generic types are used" do | ||
| expect_no_issues subject, <<-CRYSTAL | ||
| MyConst = 1 | ||
|
|
||
| my_var : String? = EMPTY_STRING | ||
|
|
||
| my_var.as(String) | ||
|
|
||
| puts StaticArray(Int32, 10) | ||
|
|
||
| class MyClass < MySuperClass | ||
| include MyModule | ||
| extend MyModule | ||
| end | ||
|
|
||
| a : Int32 = 10 | ||
|
|
||
| klass = String? | ||
|
|
||
| alias MyType = Float64 | StaticArray(Float64, 10) | ||
|
|
||
| def size : Float64 | ||
| 0.1 | ||
| end | ||
|
|
||
| lib MyLib | ||
| type MyType = Void* | ||
|
|
||
| struct MyStruct | ||
| field1, field2 : Float64 | ||
| end | ||
| end | ||
|
|
||
| fun fun_name : Int32 | ||
| 1234 | ||
| end | ||
|
|
||
| Int32 | "Float64" | ||
|
|
||
| MyClass.run | ||
| CRYSTAL | ||
| end |
There was a problem hiding this comment.
i would suggest to slipt this into smaller testcases as well. Otherwise, new examples will just be added to the same big testcase in the future.
| def visit(node : Crystal::Alias) | ||
| @rule.test(@source, node, @stack > 0) | ||
|
|
||
| incr_stack do | ||
| node.name.accept(self) | ||
| node.value.accept(self) | ||
| end | ||
|
|
||
| false | ||
| end |
There was a problem hiding this comment.
Could you recall how this visitor functions, particularly why we increment a stack and the meaning of last_is_used in the rules? It might be helpful to document this visitor for better clarity, as it's currently challenging to understand it quickly.
Similar to
Lint/UnusedLiteralandLint/UnusedComparison. Not too fond of the name so any suggestions are welcome.