Add Rule::Base.autocorrect_incompatible_with
#534
+26
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489
The issue here is that the autocorrections for
Style/VerboseBlock
andPerformance/MinMaxAfterMap
are overlapping.For
Performance/MinMaxAfterMap
, we (1) replacemap
withmax_of
and (2) remove.max
.(1) is overwritten by
Style/VerboseBlock
, which replacesmap { |i| i.size }
withmap(&.size)
.As a result, we get
My proposed fix is to run incompatible autocorrections separately instead of all at once.
So first we'll correct
Performance/MinMaxAfterMap
to get
Then, we'll correct
Style/VerboseBlock
to get