Add support for summaries in GitHubActionsFormatter
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
github-actions-formatter-summary
branch
from
a532d26 to
0276be9
Compare
| output.puts "| %s | %s | %s | %s |" % { | ||
| issue_location_value(issue) || "-", | ||
| issue.rule.severity, | ||
| issue.rule.name, |
There was a problem hiding this comment.
suggestion: Maybe the rule name could include a link to the documentation? This could be a future enhancement, of course.
There was a problem hiding this comment.
I thought about it, although atm we could only link directly to the ameba repo, since we don't have versioned docs (yet).
See related discussion in vscode-crystal-ameba repo: crystal-ameba/vscode-crystal-ameba#146 (comment)
Sija
force-pushed
the
github-actions-formatter-summary
branch
2 times, most recently
from
40dec81 to
6694730
Compare
veelenga
reviewed
Dec 9, 2024
veelenga
reviewed
Dec 9, 2024
Sija
force-pushed
the
github-actions-formatter-summary
branch
from
6694730 to
abb4d01
Compare
Sija
force-pushed
the
github-actions-formatter-summary
branch
from
abb4d01 to
d8e7136
Compare
Sija
force-pushed
the
github-actions-formatter-summary
branch
from
d8e7136 to
5ad69d3
Compare
veelenga
reviewed
Dec 11, 2024
Sija
force-pushed
the
github-actions-formatter-summary
branch
from
8c76a26 to
5ad69d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example summaries: https://github.com/crystal-ameba/ameba/actions/runs/12215160683
Followup to #527
Refs crystal-ameba/github-action#19