-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lint/TrailingRescueException
#512
Merged
Sija
merged 7 commits into
crystal-ameba:master
from
nobodywasishere:nobody/trailing-rescue
Nov 30, 2024
Merged
Add Lint/TrailingRescueException
#512
Sija
merged 7 commits into
crystal-ameba:master
from
nobodywasishere:nobody/trailing-rescue
Nov 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
requested changes
Nov 24, 2024
nobodywasishere
changed the title
Add Lint/TrailingRescueException
Add Nov 24, 2024
Lint/TrailingRescueException
Sija
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm gonna merge it, once v1.6.4 is finalized and released (which should be pretty soon). |
Sija
reviewed
Nov 26, 2024
This prevents the use of Paths as the default value for a trailing exception, and recommends the user use the block rescue instead to be able to filter by exception type
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
nobodywasishere
force-pushed
the
nobody/trailing-rescue
branch
from
November 27, 2024 16:21
6b631ec
to
03ced5d
Compare
veelenga
reviewed
Nov 27, 2024
veelenga
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the use of Paths as the default value for a trailing exception, and recommends the user use the block rescue instead to be able to filter by exception type.
Closes #242.