Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor --rules CLI switch output + add --describe <rule-name> CLI switch #390

Merged
merged 7 commits into from
Nov 5, 2023
Merged

Refactor --rules CLI switch output + add --describe <rule-name> CLI switch #390

merged 7 commits into from
Nov 5, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Jul 13, 2023 •
edited
Loading

--rules switch refactor

image

--describe <rule-name> switch

image

@Sija Sija added this to the 1.5.0 milestone Jul 13, 2023
@Sija Sija requested a review from veelenga July 13, 2023 00:23
@Sija Sija self-assigned this Jul 13, 2023
@Sija Sija changed the title Refactor --rules CLI switch Refactor --rules CLI switch output + add --describe <rule-name CLI switch Jul 13, 2023
@Sija Sija changed the title Refactor --rules CLI switch output + add --describe <rule-name CLI switch Refactor --rules CLI switch output + add --describe <rule-name> CLI switch Jul 13, 2023
veelenga
veelenga reviewed Jul 13, 2023
View reviewed changes
src/ameba/cli/cmd.cr Outdated Show resolved Hide resolved
@Sija Sija modified the milestones: 1.5.0, 1.6.0 Oct 6, 2023
@Sija Sija force-pushed the refactor-rules-cli-switch branch from c48e121 to bede3f9 Compare November 3, 2023 23:49
@Sija Sija requested a review from veelenga November 4, 2023 00:41
@Sija Sija force-pushed the refactor-rules-cli-switch branch from 183e759 to 1a2b4f9 Compare November 4, 2023 00:42
@Sija Sija force-pushed the refactor-rules-cli-switch branch from 1a2b4f9 to 3d3626a Compare November 4, 2023 00:45
veelenga
veelenga approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏
Would be great to have some tests.

@Sija
Copy link
Member Author

Sija commented Nov 5, 2023

@veelenga Sure, I've added some.

@Sija Sija force-pushed the refactor-rules-cli-switch branch 2 times, most recently from 1aa25f3 to 44329c6 Compare November 5, 2023 05:24
@Sija Sija force-pushed the refactor-rules-cli-switch branch from 44329c6 to ef16ad6 Compare November 5, 2023 05:39
@Sija Sija merged commit ddb6e3c into master Nov 5, 2023
4 checks passed
@Sija Sija deleted the refactor-rules-cli-switch branch November 5, 2023 05:44
@Sija Sija mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
enhancement feature refactor
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @veelenga