The max after the map is removed

[kojix2]

Code:

list.map { |i| i.size }.max

Ameba auto correct

ameba --fix

The map is not replaced with max_of, but simply max is removed.

list.map(&.size)

[kojix2]

The original code when I discovered this behavior was:

max = glossary_list.map { |g| g.name.size }.max.not_nil!

[Sija]

Interestingly it occurs only when both Style/VerboseBlock and Performance/MinMaxAfterMap rules are enabled and trying to auto-correct the code.

[Sija]

@FnControlOption Could you take a look at it, please?

[FnControlOption]

Hi @Sija, hope you are doing well. Unfortunately, I won’t have much time to look at this until around December 14

[Sija]

@FnControlOption Hi, I hope you're doing well. Would you have time to look at this? All the best in the New Year, btw! 🎉

[straight-shoota]

Just throwing in an idea: I'm wondering if it would make sense to order and separate rule application by category. For example, Performance rules could have higher precedence than Style: performance issues should be adressed first, before stylistic ones.

Of course it wouldn't solve the problem in general as it cannot avoid conflicts between rules in the same category. But it would reduce the problem space and fix the particular issue at hand.

[Sija]

@straight-shoota That wouldn't reduce the problem space, since the corrections are totally independent of the rule category.