Fix Style/RedundantBegin: begin-end in a proc literal

closes #80
crystal-ameba · Sep 22, 2018 · 12aa48c · 12aa48c
1 parent d7b0e10
commit 12aa48c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/spec/ameba/rule/style/redundant_begin_spec.cr b/spec/ameba/rule/style/redundant_begin_spec.cr
@@ -192,6 +192,19 @@ module Ameba::Rule::Style
       subject.catch(s).should_not be_valid
     end
 
+    it "doesn't report if begin-end block in a proc literal" do
+      s = Source.new %q(
+        foo = ->{
+          begin
+            raise "Foo!"
+          rescue ex
+            pp ex
+          end
+        }
+      )
+      subject.catch(s).should be_valid
+    end
+
     it "reports rule, pos and message" do
       s = Source.new %q(
         def method

diff --git a/src/ameba/rule/style/redundant_begin.cr b/src/ameba/rule/style/redundant_begin.cr
@@ -113,7 +113,7 @@ module Ameba::Rule::Style
         token = lexer.next_token
 
         case token.type
-        when :EOF
+        when :EOF, :"->"
           break
         when :IDENT
           return token.value == :begin if in_body?