Performance/FirstLastAfterFilter: ignore .first/.last with args

closes #104
crystal-ameba · Jun 3, 2019 · 037d1dd · 037d1dd
1 parent 9e2061c
commit 037d1dd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/spec/ameba/rule/performance/first_last_after_filter_spec.cr b/spec/ameba/rule/performance/first_last_after_filter_spec.cr
@@ -36,6 +36,13 @@ module Ameba::Rule::Performance
       subject.catch(source).should_not be_valid
     end
 
+    it "does not report if there is selected followed by first with arguments" do
+      source = Source.new %(
+        [1, 2, 3].select { |n| n % 2 == 0 }.first(2)
+      )
+      subject.catch(source).should be_valid
+    end
+
     it "reports if there is select followed by first?" do
       source = Source.new %(
         [1, 2, 3].select { |e| e > 2 }.first?

diff --git a/src/ameba/rule/performance/first_last_after_filter.cr b/src/ameba/rule/performance/first_last_after_filter.cr
@@ -45,6 +45,7 @@ module Ameba::Rule::Performance
 
     def test(source, node : Crystal::Call)
       return unless CALL_NAMES.includes?(node.name) && (obj = node.obj)
+      return if node.args.any?
 
       if node.block.nil? && obj.is_a?(Crystal::Call) &&
          filter_names.includes?(obj.name) && !obj.block.nil?