Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: debug_traceCall RPC #390

Merged

Conversation

XinyuCRO
Copy link

@XinyuCRO XinyuCRO commented Jan 5, 2024

This PR introduces the debug_traceCall RPC method

This PR adds the missing commit sign, aiming to replace the original #384. Due to the missing commit sign in the middle of the original PR, it's a lot of pain to rebase(too much conflict to resolve), I open this PR to replace the original one, and their changes are the same

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@XinyuCRO XinyuCRO mentioned this pull request Jan 5, 2024
11 tasks
return 0, errorsmod.Wrapf(errortypes.ErrInvalidHeight, "uint value %v cannot exceed %v", value, int(math.MaxInt64))
}

return int(value), nil

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@yihuang yihuang self-requested a review January 5, 2024 03:24
@yihuang yihuang merged commit ec8d73f into crypto-org-chain:develop Jan 5, 2024
27 of 30 checks passed
@yihuang yihuang deleted the feature/debug_tracecall_debug branch January 5, 2024 06:53
@yihuang yihuang mentioned this pull request Jan 5, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants