Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no int64 check in error msg #388

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 19, 2023

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe changed the title Problem: no in64 check in error msg Problem: no int64 check in error msg Dec 19, 2023
@mmsqe mmsqe requested a review from yihuang December 19, 2023 13:47
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #388 (ac2cb26) into release/v0.20.x-cronos (0cd23d4) will not change coverage.
Report is 1 commits behind head on release/v0.20.x-cronos.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/v0.20.x-cronos     #388   +/-   ##
=======================================================
  Coverage                   56.80%   56.80%           
=======================================================
  Files                         113      113           
  Lines                       10595    10595           
=======================================================
  Hits                         6018     6018           
  Misses                       4324     4324           
  Partials                      253      253           
Files Coverage Δ
app/ante/fees.go 96.84% <100.00%> (ø)

@mmsqe mmsqe merged commit a85daed into crypto-org-chain:release/v0.20.x-cronos Dec 20, 2023
24 of 27 checks passed
mmsqe added a commit that referenced this pull request Dec 21, 2023
* Problem: no in64 check in error msg

* Update CHANGELOG.md

Signed-off-by: mmsqe <[email protected]>

---------

Signed-off-by: mmsqe <[email protected]>
mmsqe added a commit that referenced this pull request Dec 22, 2023
* Problem: no int64 check in error msg

* Update CHANGELOG.md



---------

Signed-off-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants