Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing nil check when cancel filter #386

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 17, 2023

cancel is no use now but can keep as optional callback later

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe marked this pull request as ready for review December 17, 2023 02:48
@mmsqe mmsqe requested a review from yihuang December 17, 2023 02:48
@mmsqe mmsqe merged commit 1682afb into crypto-org-chain:release/v0.20.x-cronos Dec 18, 2023
16 of 19 checks passed
mmsqe added a commit that referenced this pull request Dec 18, 2023
* Problem: f.cancel nil is not checked

* Update CHANGELOG.md



* cleanup

---------

Signed-off-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants