Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no flexible way to adjust gas prices per-node in mempool #385

Closed
wants to merge 6 commits into from
Closed

Problem: no flexible way to adjust gas prices per-node in mempool #385

wants to merge 6 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 12, 2023 •
edited
Loading

Solution:

  • rpc will respect the per-node min-gas-price value set in config
  • validator will also check the min-gas-price at the same time as eip-1559 logic.

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang changed the title Problem: no way to adjust gas prices per-node Problem: no flexible way to adjust gas prices per-node in mempool Dec 12, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2023
View reviewed changes
app/ante/eth.go

evmDenom := params.EvmDenom
feeAmt := ethMsg.GetFee()
glDec := sdk.NewDec(int64(ethMsg.GetGas()))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion

Potential integer overflow by integer type conversion
@yihuang yihuang marked this pull request as draft December 12, 2023 23:43
mmsqe
mmsqe reviewed Dec 13, 2023
View reviewed changes
@yihuang
Problem: no way to adjust gas prices per-node
e7a3c3e 
Solution:
- more flexible way to adjust gas-price per-node in mempool logic

change the gas-price as well

changelog

add nil check

fix feeHistory api
@yihuang yihuang force-pushed the release/v0.20.x-cronos branch from e0b09da to e7a3c3e Compare December 13, 2023 05:47
@yihuang yihuang closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsqe mmsqe mmsqe left review comments

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @mmsqe @thomas-nguy