Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fix of deadlock when close tree is not included #1725

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Dec 18, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

for more info

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes

    • Addressed deadlock issue when closing the tree in the iavl module.
    • Resolved nil pointer error when querying blocks before the feemarket module is enabled.
    • Registered legacy codec for querying historical transactions from removed modules.
  • Improvements

    • Upgraded rocksdb to version v9.8.4.
  • Dependencies

    • Updated several module dependencies to newer versions for improved compatibility and security.

@mmsqe mmsqe requested a review from a team as a code owner December 18, 2024 01:52
@mmsqe mmsqe requested review from devashishdxt and thomas-nguy and removed request for a team December 18, 2024 01:52
Copy link
Contributor

coderabbitai bot commented Dec 18, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""

Walkthrough

This pull request involves updates to the CHANGELOG.md and go.mod files for the Cronos project. The changes include adding bug fixes for the iavl module, addressing nil pointer errors, and registering legacy codecs. The go.mod file has been extensively updated with multiple dependency replacements and version upgrades, primarily focusing on modules related to Cosmos SDK, Ethereum, and other core libraries.

Changes

File Change Summary
CHANGELOG.md - Added bug fix for deadlock in iavl module (UNRELEASED)
- Added bug fix for nil pointer error when querying blocks
- Added fix for registering legacy codec for historical transactions
- Noted improvement of rocksdb upgrade to v9.8.4
go.mod - Updated multiple dependencies with new versions
- Replaced several modules with crypto-org-chain forks
- Updated key libraries like iavl, cosmos-sdk, ethereum, and cometbft

Possibly related PRs

Suggested reviewers

  • JayT106
  • calvinaco
  • yihuang

Poem

🐰 Hop, hop, through code's domain,
Modules dance, dependencies reign!
Fixing bugs with rabbit's might,
Upgrading systems, making them bright 🚀
Cronos evolves, one commit at a time!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b1f1b2 and 8049984.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod
🔇 Additional comments (2)
CHANGELOG.md (2)

8-8: LGTM! The changelog entry follows the standard format.

The new entry properly documents the bug fix with:


Line range hint 1-1200: The changelog structure follows best practices.

The changelog maintains a clear and consistent format with:

  • Reverse chronological ordering
  • Clear section headers (UNRELEASED, Bug Fixes, etc.)
  • Proper versioning
  • Links to relevant PRs
  • Detailed descriptions of changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mmsqe mmsqe enabled auto-merge December 18, 2024 01:53
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.56%. Comparing base (a3c2f70) to head (8049984).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1725       +/-   ##
===========================================
+ Coverage   16.87%   35.56%   +18.68%     
===========================================
  Files          72      126       +54     
  Lines        6163    11915     +5752     
===========================================
+ Hits         1040     4237     +3197     
- Misses       5000     7254     +2254     
- Partials      123      424      +301     

see 71 files with indirect coverage changes

@mmsqe mmsqe added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 18, 2024
@mmsqe mmsqe enabled auto-merge December 18, 2024 03:05
@mmsqe mmsqe added this pull request to the merge queue Dec 18, 2024
Merged via the queue into crypto-org-chain:main with commit d03b8d8 Dec 18, 2024
44 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants