Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: v1.4.0-rc6 is not released #1704

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Problem: v1.4.0-rc6 is not released #1704

merged 2 commits into from
Nov 26, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 26, 2024 •
edited by coderabbitai bot
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Documentation
    • Updated CHANGELOG.md to reflect new releases and their changes, including bug fixes and improvements.
    • Added details for version v1.4.0-rc6, highlighting a pruning bug fix and an update to the ibc-go library.

@yihuang yihuang requested a review from a team as a code owner November 26, 2024 09:20
@yihuang yihuang requested review from devashishdxt, leejw51crypto and mmsqe and removed request for a team November 26, 2024 09:20
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2024 •
edited
Loading

Walkthrough

The CHANGELOG.md file has been updated to document the latest release, version v1.4.0-rc6, which includes a bug fix for the iavl library and an update to the ibc-go library. Previous entries in the changelog detail various changes across earlier releases, including breaking changes, bug fixes, and improvements related to transaction processing and state machine behavior. The document serves as a comprehensive record of incremental changes affecting the project.

Changes

File Change Summary
CHANGELOG.md Updated to reflect release v1.4.0-rc6, including a bug fix for iavl library and ibc-go update. Previous versions documented include v1.4.0-rc5, v1.4.0-rc4, v1.4.0-rc3, and v1.4.0-rc2 with various changes.

Possibly related PRs

Suggested reviewers

  • mmsqe
  • calvinaco

🐇 In the changelog we hop,
With fixes and updates on top.
Version six, oh what a delight,
IAVL and ibc-go shine bright!
Each entry a tale, each bug a foe,
In our project, we continue to grow! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

Line range hint 3-13: LGTM! Consider adding more details about the iavl pruning fix.

The changelog entries are well-structured and properly referenced with PR links. However, it would be helpful to add a brief explanation of what the iavl pruning fix addresses, as this could be important for node operators.

Consider expanding the bug fix entry to include more context:

- * [#1702](https://github.com/crypto-org-chain/cronos/pull/1702) Update iavl to include prune fix.
+ * [#1702](https://github.com/crypto-org-chain/cronos/pull/1702) Update iavl to include prune fix that addresses [brief description of the issue].
🧰 Tools
🪛 Markdownlint (0.35.0)

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 81dfc33 and c4cc00e.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.35.0)
CHANGELOG.md

3-3: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

@yihuang yihuang added this pull request to the merge queue Nov 26, 2024
Merged via the queue into crypto-org-chain:main with commit 86c5cc4 Nov 26, 2024
30 checks passed
@yihuang yihuang deleted the rc6 branch November 26, 2024 09:34
This was referenced Dec 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mmsqe mmsqe mmsqe approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @mmsqe