Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no trace detail on insufficient balance fix is not included #1679

Merged
merged 2 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Bug Fixes

* [#1679](https://github.com/crypto-org-chain/cronos/pull/1679) Include no trace detail on insufficient balance fix.

*Nov 6, 2024*

## v1.4.0-rc3
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require (
cosmossdk.io/x/upgrade v0.1.4
filippo.io/age v1.1.1
github.com/99designs/keyring v1.2.2
github.com/cometbft/cometbft v0.38.13
github.com/cometbft/cometbft v0.38.15
github.com/cosmos/cosmos-db v1.0.3-0.20240408151834-e75f6e4b28d8
github.com/cosmos/cosmos-sdk v0.50.9
github.com/cosmos/gogoproto v1.7.0
Expand Down Expand Up @@ -273,7 +273,7 @@ replace (
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.20-0.20240926023215-d2275b4afb9a
// develop
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20241101134753-e4d00df93541
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20241108020006-836617d21619
// Fix upstream GHSA-h395-qcrw-5vmq and GHSA-3vp4-m3rf-835h vulnerabilities.
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,8 @@ github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20241018012743-d78d66e74712
github.com/crypto-org-chain/cosmos-sdk/store v0.0.0-20241018012743-d78d66e74712/go.mod h1:8DwVTz83/2PSI366FERGbWSH7hL6sB7HbYp8bqksNwM=
github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20241018012743-d78d66e74712 h1:vvN3FqhFTakKy4jgVC1GoEtHW52zQg49uNE/e16Scu8=
github.com/crypto-org-chain/cosmos-sdk/x/tx v0.0.0-20241018012743-d78d66e74712/go.mod h1:V6DImnwJMTq5qFjeGWpXNiT/fjgE4HtmclRmTqRVM3w=
github.com/crypto-org-chain/ethermint v0.6.1-0.20241101134753-e4d00df93541 h1:LXTYeYCOj8KWGolxz3NJGq0iMnw5pywmMDkZGhdZqME=
github.com/crypto-org-chain/ethermint v0.6.1-0.20241101134753-e4d00df93541/go.mod h1:bDouX0WGx+JWkT61l8uSUFqaj+WLOfZv0nxlirm3gsM=
github.com/crypto-org-chain/ethermint v0.6.1-0.20241108020006-836617d21619 h1:zW3yTgu0cp5pzsikWT26JULera27jnxLMG2Rxrmwo10=
github.com/crypto-org-chain/ethermint v0.6.1-0.20241108020006-836617d21619/go.mod h1:bDouX0WGx+JWkT61l8uSUFqaj+WLOfZv0nxlirm3gsM=
github.com/crypto-org-chain/go-block-stm v0.0.0-20240919080136-6c49aef68716 h1:OvD5Rm0B6LHUJk6z858UgwdP72jU2DuUdXeclRyKpDI=
github.com/crypto-org-chain/go-block-stm v0.0.0-20240919080136-6c49aef68716/go.mod h1:iwQTX9xMX8NV9k3o2BiWXA0SswpsZrDk5q3gA7nWYiE=
github.com/crypto-org-chain/go-ethereum v1.10.20-0.20240926023215-d2275b4afb9a h1:IUPD+dg1YQl8cLocxQ/Mbx/ObTgAgcrZlcBhFjsLO40=
Expand Down
6 changes: 3 additions & 3 deletions gomod2nix.toml

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions integration_tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -797,12 +797,11 @@ def test_failed_transfer_tx(cronos):
assert not result["failed"]
assert receipt.gasUsed == result["gas"]
else:
assert rsp["error"] == {
"code": -32000,
"message": (
"rpc error: code = Internal desc = "
"insufficient balance for transfer"
),
assert rsp["result"] == {
"failed": False,
"gas": 21000,
"returnValue": "",
"structLogs": [],
}


Expand Down
3 changes: 1 addition & 2 deletions store/go.mod
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module github.com/crypto-org-chain/cronos/store

go 1.22
toolchain go1.22.8
go 1.22.7

require (
cosmossdk.io/errors v1.0.1
Expand Down
2 changes: 0 additions & 2 deletions versiondb/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module github.com/crypto-org-chain/cronos/versiondb

go 1.22

toolchain go1.22.0

require (
cosmossdk.io/errors v1.0.1
cosmossdk.io/log v1.3.1
Expand Down
Loading