Problem: recent fixes not released #1278
Conversation
Solution: - merge into the un-released rc2 veresion
WalkthroughThe latest release, v1.1.0-rc2, brings a notable upgrade capability with support for hard-fork style changes. It also includes an update to ethermint and cosmos-sdk, along with the introduction of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
Signed-off-by: yihuang <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| feeparams.ElasticityMultiplier = 4 | ||
| feeparams.BaseFee = sdk.NewInt(10000000000000) | ||
| feeparams.MinGasPrice = sdk.NewDec(10000000000000) | ||
| app.FeeMarketKeeper.SetParams(ctx, feeparams) |
Check warning
Code scanning / gosec
Errors unhandled. Warning
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 35.77% 35.75% -0.03%
==========================================
Files 116 116
Lines 10663 10670 +7
==========================================
Hits 3815 3815
- Misses 6471 6478 +7
Partials 377 377
|
yihuang
requested review from
JayT106 and
calvinaco
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/upgrades.go (1 hunks)
Additional comments: 6
app/upgrades.go (2)
134-139: The changes to the fee market parameters look correct, but ensure that the new values for
BaseFeeChangeDenominator,ElasticityMultiplier,BaseFee, andMinGasPriceare consistent with the system's requirements and have been reviewed by the domain experts for economic implications.139-139:
CHANGELOG.md (4)
3-14: The changelog correctly reflects the updates for version v1.1.0-rc2, including support for hard-fork style upgrades, updates to Ethermint and Cosmos-SDK, enabling the
push0opcode in integration tests, removal of the authz module, and a bug fix for concurrent write in fee history.9-9: The update to the integration test enabling the
push0opcode is mentioned, which is good as it reflects changes in testing procedures that could affect how features are validated.7-7: The inclusion of support for hard-fork style upgrades is correctly documented, which is crucial as it indicates significant protocol-level changes.
8-8: The updates to Ethermint and Cosmos-SDK are mentioned, which is important for tracking dependency updates and potential impacts on the system's stability and functionality.
|
/runsims |
|
/runsim |
|
Simulation tests get triggered and started by |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (5)
- client/docs/config.json
- client/docs/swagger-ui/swagger.yaml
- go.mod
- go.sum
- gomod2nix.toml
Files selected for processing (1)
- app/test_helpers.go (1 hunks)
Additional comments: 1
app/test_helpers.go (1)
- 44-44: The
SimBlockMaxGasconstant has been increased from81500000to815000000. Ensure that this tenfold increase is intentional and that all tests and simulations that rely on this value are still valid and performant with this new limit.
|
❌ |
86ad7b3
Solution:
Updates
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
New Features
push0opcode functionality.Updates
Bug Fixes
Refactor
Chores