Problem: no easy way to detect error ack packet

check underlying_app_success
crypto-org-chain · Oct 9, 2024 · de587a8 · de587a8
1 parent fb902d2
commit de587a8
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/x/cronos/keeper/keeper.go b/x/cronos/keeper/keeper.go
@@ -317,6 +317,9 @@ func (k Keeper) IBCOnAcknowledgementPacketCallback(
 	if err := k.cdc.UnmarshalJSON(acknowledgement, &ack); err != nil {
 		return err
 	}
+	if !ack.UnderlyingAppSuccess {
+		return k.onPacketResult(ctx, packet, false, relayer, contractAddress, packetSenderAddress)
+	}
 	var res channeltypes.Acknowledgement
 	if err := k.cdc.UnmarshalJSON(ack.AppAcknowledgement, &res); err != nil {
 		return err