simplify callback

crypto-org-chain · Nov 8, 2023 · 2497b65 · 2497b65
1 parent 5c4ccfa
commit 2497b65
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/integration_tests/contracts/contracts/TestICA.sol b/integration_tests/contracts/contracts/TestICA.sol
@@ -106,7 +106,7 @@ contract TestICA {
         return statusMap[packetSrcChannel][seq];
     }
 
-    function onPacketResultCallback(uint64 seq, bool ack, string calldata packetSrcChannel, string calldata packetDstChannel) external payable returns (bool) {
+    function onPacketResultCallback(string calldata packetSrcChannel, uint64 seq, bool ack) external payable returns (bool) {
         // To prevent called by arbitrary user
         require(msg.sender == module_address);
         Status status = Status.FAIL;

diff --git a/x/cronos/events/bindings/cosmos/precompile/icacallback/i_ica_callback.abigen.go b/x/cronos/events/bindings/cosmos/precompile/icacallback/i_ica_callback.abigen.go
diff --git a/x/cronos/events/bindings/src/ICACallback.sol b/x/cronos/events/bindings/src/ICACallback.sol
@@ -2,5 +2,5 @@
 pragma solidity ^0.8.4;
 
 interface IICACallback {
-    function onPacketResultCallback(uint64 seq, bool ack, string calldata packetSrcChannel, string calldata packetDstChannel) external payable returns (bool);
+    function onPacketResultCallback(string calldata packetSrcChannel, uint64 seq, bool ack) external payable returns (bool);
 }
diff --git a/x/cronos/keeper/keeper.go b/x/cronos/keeper/keeper.go
@@ -292,7 +292,7 @@ func (k Keeper) onPacketResult(
 	packetSenderAddress string,
 ) error {
 	contractAddr := common.HexToAddress(contractAddress)
-	data, err := cronosprecompiles.OnPacketResultCallback(packet.Sequence, acknowledgement, packet.SourceChannel, packet.DestinationChannel)
+	data, err := cronosprecompiles.OnPacketResultCallback(packet.SourceChannel, packet.Sequence, acknowledgement)
 	if err != nil {
 		return err
 	}