Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: yihuang <[email protected]>
  • Loading branch information
yihuang authored Jan 17, 2025
1 parent 63dd7aa commit 21be818
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion integration_tests/test_mempool.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
CONTRACTS,
KEYS,
deploy_contract,
send_transaction,
send_txs,
sign_transaction,
wait_for_new_blocks,
Expand Down Expand Up @@ -91,6 +90,8 @@ def test_mempool_nonce(cronos_mempool):
the tx body is so large that they won't be included in next block at the same time,
then we'll try to send a new tx with local nonce to see if it still get accepted even if

Check failure on line 91 in integration_tests/test_mempool.py

View workflow job for this annotation

GitHub Actions / Lint python

./integration_tests/test_mempool.py:91:89: E501 line too long (92 > 88 characters)
check-tx state get reset.
the expected behavior is when mempool.recheck=true, this test should pass, because although check-tx state get reset when new blocks generated, but recheck logic will bring it back in sync with pending txs, so the client can keep sending new transactions with local nonce.

Check failure on line 94 in integration_tests/test_mempool.py

View workflow job for this annotation

GitHub Actions / Lint python

./integration_tests/test_mempool.py:94:89: E501 line too long (276 > 88 characters)
"""
w3: Web3 = cronos_mempool.w3
cli = cronos_mempool.cosmos_cli(0)
Expand Down

0 comments on commit 21be818

Please sign in to comment.