Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new error codes #37

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

muneebkq
Copy link
Collaborator

No description provided.

@muneebkq muneebkq requested a review from ahmad-kemsan July 31, 2024 11:58
@ahmad-kemsan
Copy link
Collaborator

@muneebkq Why is the entire file changed? I expected only a few error codes to be added here? Also, you missed to map the error code with the exceptions in the lexfloatclient-exceptions.ts. Please address this.

* MESSAGE: Request blocked due to untrusted proxy.
*/
LF_E_PROXY_NOT_TRUSTED = 67,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Please check the formatting and doc style

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@muneebkq muneebkq requested a review from ahmad-kemsan August 6, 2024 07:00
@ahmad-kemsan ahmad-kemsan merged commit 8840855 into borrowing-develop Aug 6, 2024
@muneebkq muneebkq deleted the muneeb/status-code branch January 17, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants