-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add maxmind env var for geoip #13
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b39137e
chore: add maxmind env var for geoip
saalim-mushtaq 3c9128e
chore: add maxmind accound id env var
saalim-mushtaq 70ed09f
chore: update env var for web-api service
saalim-mushtaq d2da2e1
chore: add space
saalim-mushtaq d36517c
chore: remove unwanted space
saalim-mushtaq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,9 @@ services: | |
|
||
geoip: | ||
image: cryptlex/freegeoip:latest | ||
environment: | ||
MAXMIND_LICENSE_KEY: ${MAXMIND_LICENSE_KEY} | ||
MAXMIND_ACCOUNT_ID: ${MAXMIND_ACCOUNT_ID} | ||
ports: | ||
- 8080 | ||
networks: | ||
|
@@ -110,6 +113,8 @@ services: | |
REDIS_URL: # redis://cache:6379 - not required for single machine deployment | ||
GEOIPSERVER_URL: http://geoip:8080/json | ||
GOOGLE_CLIENT_ID: ${GOOGLE_CLIENT_ID} | ||
MAXMIND_LICENSE_KEY: ${MAXMIND_LICENSE_KEY} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MAXMIND_LICENSEKEY: ${MAXMIND_LICENSE_KEY} @saalim-mushtaq update here web api service has slightly different name for this env |
||
MAXMIND_ACCOUNT_ID: ${MAXMIND_ACCOUNT_ID} | ||
networks: | ||
- backend | ||
restart: unless-stopped | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saalim-mushtaq space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saalim-mushtaq space after MAXMIND_ACCOUNT_ID env