Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Katherine,
Thanks for your awesome work. I open the issue to ask for credits of DEIS sampler.
Concurrent DPM-Solver~(second order and third order) and Heun method in Elucidate work is in fact exponential RK method with specific underlying RK solvers,
Despite different motivations, equation 18 is the key for DPM-Solver and Heun in Elucidate work. And two changes of variables$t <-> \rho$ and $x <->y$ are equivalent to "rescaling" in Elucidate work. And we can use more RK solvers for eq-18. Empirical comparisons among several RK solvers are also included in DEIS.
I know it is a bot area, but it is frustrating to be "scooped" and lose credits for a young researcher. Can you consider some modifications and have some credits for DEIS work?
Thanks,
qsh