Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crowdint/rails3-jquery-autocomplete#249 Enable setting check boxes... #250

Merged
merged 3 commits into from
Mar 20, 2014
Merged

Fixes crowdint/rails3-jquery-autocomplete#249 Enable setting check boxes... #250

merged 3 commits into from
Mar 20, 2014

Conversation

donv
Copy link
Contributor

@donv donv commented Jan 7, 2014

...when an autocomplete entry is selected

@donv
Copy link
Contributor Author

donv commented Jan 7, 2014

The second commit fixes Issue #226 as well.

* Supersedes #159 Add option to send additional fields with the auto complete query. feature
@donv
Copy link
Contributor Author

donv commented Feb 18, 2014

Hi!

Any chance this could be merged soon?

@bigtunacan bigtunacan self-assigned this Feb 18, 2014
@bigtunacan
Copy link
Contributor

@donv , I understand the checkbox issue. I'm a little unclear though how this addresses issue #226 as well as what you are using the data-autocomplete-fields for; could you provide some additional clarification?

@donv
Copy link
Contributor Author

donv commented Feb 18, 2014

Hi @bigtunacan !

I think #226 is caused by rails3-autocomplete clearing fields even if they are not selected by the data-id-element.

data-autocomplete-fields is a new feature enabling developers to send additional fields with the autocomplete server request allowing the autocomplete field to display different choices based on secondary form elements.

bigtunacan added a commit that referenced this pull request Mar 20, 2014
Fixes #249 Enable setting check boxes...
@bigtunacan bigtunacan merged commit 0a6e4ae into crowdint:master Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants