chore: TypeScriptify Games #2966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted everything related to games over to typescript. - Excluding the game-manager and built-in game loader. - Culled several needless helix calls from games. - Found and squished a few obscure bugs along the journey. - Probably added a dozen more random bugs, though... - Apparanty currency selection controls can't be "required?" - rev.2: now with more JSDoc and less derp.
phroggster
force-pushed
the
gamers-gonna-game
branch
from
a900aea to
2931c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Games to TypeScript
requiredflag?If and when this PR gets properly reviewed, tested, and merged, you must also merge firebot-custom-scripts-types#35 to expose these changes to third-party scripts.
Applicable Issues
None
Testing
Some. This will need some more thorough testing prior to merge, though.
Screenshots
N/A