Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for go mod tidy #77

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add check for go mod tidy #77

merged 1 commit into from
Nov 29, 2024

Conversation

Moulick
Copy link
Contributor

@Moulick Moulick commented Jul 30, 2024

Description of your changes

ref: crossplane-contrib/function-go-templating#105 (comment)

  1. It looks like the go.sum is very bloated due to missing cleanup. All I have done is run go mod tidy to remove unused dependencies. This is generally a good practice and results in faster downloads/less cache.
  2. Also added config to renovate to instruct it to do the go mod tidy whenever it upgrades a dependency.
  3. Add a check in lint to catch future missing cleanup

I have:

  • Read and followed Crossplane's contribution process.
  • Run go test ./...
  • Added or updated unit tests for my change.

@Moulick
Copy link
Contributor Author

Moulick commented Jul 30, 2024

@jbw976 Here you go! Could you please approve running the pipeline 😄

@Moulick
Copy link
Contributor Author

Moulick commented Jul 31, 2024

@jbw976 looks good to merge IMHO

@Moulick
Copy link
Contributor Author

Moulick commented Aug 7, 2024

@jbw976 hey, anything holding this up?

@Moulick Moulick force-pushed the main branch 2 times, most recently from cd91012 to ad09846 Compare October 10, 2024 05:28
@Moulick
Copy link
Contributor Author

Moulick commented Oct 10, 2024

So looks like the go.mod has been cleaned up in some other PR. Can we merge this one soon so the GitHub Actions and Renovate config gets in?

@Moulick Moulick changed the title Check and run go mod tidy Add check for go mod tidy Oct 10, 2024
@ezgidemirel
Copy link
Member

Hi @Moulick thanks a lot for your contribution! Do you mind rebasing the PR?

@Moulick
Copy link
Contributor Author

Moulick commented Nov 29, 2024

@ezgidemirel Done, could you please run the CI again?

Add a step to check for go mod tidy in the CI workflow. Also configure renovate to run go mod tidy when bumping dependencies.

Signed-off-by: Moulick Aggarwal <[email protected]>
Copy link
Member

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM!

@ezgidemirel ezgidemirel merged commit 5fc63ba into crossplane:main Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants