-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/elasticache user group association #1648
base: main
Are you sure you want to change the base?
Feature/elasticache user group association #1648
Conversation
152bdba
to
6a85467
Compare
/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml" |
@ulucinar @sergenyalcin @turkenf @mbbush - I think the PR is read for review :) |
/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml" |
@turkenf I see the uptest has failed, do I need to do something? |
Hi @ido-re,
You can check why it failed in the uptest logs. The test failed with the error below, sometimes the connection error can be temporary. I will trigger the test again. If it fails with the same error, please try using the v1beta1 versions of all resources in the example.
|
/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml" |
edaa4da
to
09b69d9
Compare
@turkenf - thank you, Following your suggestion, I changed the example files to use v1beta1 |
Thanks for the update @ido-re, I think you have accidentally updated the generated example here. This is not required since we are not using the generated examples when testing. Can you please change the default User resource version under the examples folder instead? |
b518b4c
to
9e34318
Compare
ho I missed it, fixed it now @turkenf |
/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml" |
Signed-off-by: yurhasko <[email protected]> Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
Signed-off-by: ido-re <[email protected]>
8d49958
to
5d95111
Compare
@turkenf is it possible to run again the automation test? |
/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml" |
@turkenf I see the last failer is: |
If you scroll through the logs in the Uptest run, you can see messages in the conditions section of the resources about why the test failed. For example, I see the following message in the
My advice to you here is to first test/validate the resource manually. Please see: Running Uptest locally, Manual Test |
Description of your changes
Allow Elasticach users to associate with Elasticach Usergroup.
This resource will allow you to create Elasticach (Redis) User and associate with an existing user group
Fixes #1620
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested