Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/elasticache user group association #1648

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ido-re
Copy link

@ido-re ido-re commented Jan 24, 2025

Description of your changes

Allow Elasticach users to associate with Elasticach Usergroup.
This resource will allow you to create Elasticach (Redis) User and associate with an existing user group

Fixes #1620

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@ido-re ido-re force-pushed the feature/elasticache_user_group_association branch from 152bdba to 6a85467 Compare January 24, 2025 10:42
@ido-re
Copy link
Author

ido-re commented Jan 24, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@ido-re
Copy link
Author

ido-re commented Jan 24, 2025

@ulucinar @sergenyalcin @turkenf @mbbush - I think the PR is read for review :)

@turkenf
Copy link
Collaborator

turkenf commented Jan 24, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@ido-re
Copy link
Author

ido-re commented Jan 25, 2025

@turkenf I see the uptest has failed, do I need to do something?

@turkenf
Copy link
Collaborator

turkenf commented Jan 27, 2025

Hi @ido-re,
Congratulations on your first contribution 🎉

@turkenf I see the uptest has failed, do I need to do something?

You can check why it failed in the uptest logs. The test failed with the error below, sometimes the connection error can be temporary. I will trigger the test again. If it fails with the same error, please try using the v1beta1 versions of all resources in the example.

case.go:363: conversion webhook for elasticache.aws.upbound.io/v1beta2, Kind=User failed: Post "https://provider-aws-elasticache.upbound-system.svc:9443/convert?timeout=30s": dial tcp 10.96.250.111:9443: connect: connection refused
    case.go:363: conversion webhook for elasticache.aws.upbound.io/v1beta2, Kind=User failed: Post "https://provider-aws-elasticache.upbound-system.svc:9443/convert?timeout=30s": dial tcp 10.96.250.111:9443: connect: connection refused

@turkenf
Copy link
Collaborator

turkenf commented Jan 27, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@ido-re ido-re force-pushed the feature/elasticache_user_group_association branch from edaa4da to 09b69d9 Compare January 27, 2025 10:13
@ido-re
Copy link
Author

ido-re commented Jan 27, 2025

@turkenf - thank you, Following your suggestion, I changed the example files to use v1beta1

@turkenf
Copy link
Collaborator

turkenf commented Jan 27, 2025

@turkenf - thank you, Following your suggestion, I changed the example files to use v1beta1.

Thanks for the update @ido-re,

I think you have accidentally updated the generated example here. This is not required since we are not using the generated examples when testing.

Can you please change the default User resource version under the examples folder instead?

@ido-re ido-re force-pushed the feature/elasticache_user_group_association branch from b518b4c to 9e34318 Compare January 27, 2025 16:32
@ido-re
Copy link
Author

ido-re commented Jan 27, 2025

@turkenf - thank you, Following your suggestion, I changed the example files to use v1beta1.

Thanks for the update @ido-re,

I think you have accidentally updated the generated example here. This is not required since we are not using the generated examples when testing.

Can you please change the default User resource version under the examples folder instead?

ho I missed it, fixed it now @turkenf

@turkenf
Copy link
Collaborator

turkenf commented Jan 27, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@ido-re ido-re force-pushed the feature/elasticache_user_group_association branch from 8d49958 to 5d95111 Compare January 28, 2025 06:58
@ido-re
Copy link
Author

ido-re commented Jan 28, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@turkenf is it possible to run again the automation test?
I rollbacked the changes I made on examples-generated/elasticache/v1beta1/usergroupassociation.yaml following your comment and because the diff test was failed

@turkenf
Copy link
Collaborator

turkenf commented Jan 28, 2025

/test-examples="examples/elasticache/v1beta1/usergroupassociation.yaml"

@ido-re
Copy link
Author

ido-re commented Jan 28, 2025

@turkenf I see the last failer is:
uptest-v0.13.0: error: cannot run e2e tests successfully: cannot execute tests: kuttl failed: exit status 1
Do you have suggestions for solving the issue?

@turkenf
Copy link
Collaborator

turkenf commented Jan 28, 2025

@turkenf I see the last failer is:
uptest-v0.13.0: error: cannot run e2e tests successfully: cannot execute tests: kuttl failed: exit status 1
Do you have suggestions for solving the issue?

If you scroll through the logs in the Uptest run, you can see messages in the conditions section of the resources about why the test failed. For example, I see the following message in the UserGroupAssociation conditions:

    logger.go:42: 10:04:35 | case/0-apply |     - lastTransitionTime: "2025-01-28T10:04:03Z"
    logger.go:42: 10:04:35 | case/0-apply |       message: 'create failed: async create failed: failed to create the resource:
    logger.go:42: 10:04:35 | case/0-apply |         [{0 creating ElastiCache User Group Association (example,example): operation
    logger.go:42: 10:04:35 | case/0-apply |         error ElastiCache: ModifyUserGroup, https response error StatusCode: 404,
    logger.go:42: 10:04:35 | case/0-apply |         RequestID: 9c32e451-ecc9-45bb-be9c-fb43aaf1b603, UserNotFound: User example
    logger.go:42: 10:04:35 | case/0-apply |         not found.  []}]'

My advice to you here is to first test/validate the resource manually. Please see: Running Uptest locally, Manual Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for aws_elasticache_user_group_association resource
3 participants