Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Additional HTTP Methods in Method Field #77

Conversation

arielsepton
Copy link
Member

This PR extends the supported HTTP methods in the Method field of the Mapping type of the Request managed resource.
The current implementation only allows POST, GET, PUT, and DELETE. However, some remote APIs require additional HTTP methods such as PATCH, HEAD, or OPTIONS for specific actions.

To address this limitation, this PR updates the kubebuilder:validation:Enum marker and the CRD schema to include the following methods:

  • PATCH
  • HEAD
  • OPTIONS

This change ensures that users can define mappings using these methods without encountering validation errors.

Fixes

Fixes #76

Checklist

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

Ariel Septon added 2 commits January 3, 2025 14:24
Signed-off-by: Ariel Septon <[email protected]>
@arielsepton arielsepton merged commit 511cf20 into crossplane-contrib:main Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request mapping does not support HTTP methods other an POST, GET, PUT, DELETE
1 participant