Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PUT mapping validation check #23

Merged
merged 2 commits into from
May 16, 2024

Conversation

arielsepton
Copy link
Member

Description

This PR adds a validation check to ensure that a PUT mapping exists before comparing the PUT body with the GET response.
The comparison is performed to verify if the PUT body is contained within the GET response, ensuring that the resource is up to date.
If the PUT mapping is not found, the comparison step is skipped, preventing potential errors. This enhancement improves the reliability and accuracy of resource provisioning.

Fixes #22

How has this code been tested

I have added a test case to cover this fix and ensured that all existing tests pass.

@arielsepton arielsepton requested a review from jbw976 May 16, 2024 22:16
@arielsepton arielsepton merged commit 42e6921 into crossplane-contrib:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic after GET: interface conversion: interface {} is nil, not string [recovered]
1 participant