Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd: let helper scripts work not just from / #1411

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

ydirson
Copy link
Contributor

@ydirson ydirson commented Jan 9, 2024

Scripts should not source their libs as if they were going to be run with PWD=/

@ydirson ydirson requested a review from a team as a code owner January 9, 2024 12:47
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Jan 9, 2024
Scripts fixed here were not previously advertised, do that now.

Signed-off-by: Yann Dirson <[email protected]>
@Emilgardis Emilgardis added CI-aarch64-unknown-freebsd Run CI for aarch64-unknown-freebsd target CI-i686-unknown-freebsd Run CI for i686-unknown-freebsd target CI-x86_64-unknown-freebsd Run CI for x86_64-unknown-freebsd target labels Jan 9, 2024
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Emilgardis Emilgardis added this pull request to the merge queue Jan 9, 2024
Merged via the queue into cross-rs:main with commit 3fc1838 Jan 9, 2024
24 checks passed
@ydirson ydirson deleted the freebsd-scripts-path branch January 10, 2024 08:50
@Emilgardis Emilgardis added this to the v0.3.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-aarch64-unknown-freebsd Run CI for aarch64-unknown-freebsd target CI-i686-unknown-freebsd Run CI for i686-unknown-freebsd target CI-x86_64-unknown-freebsd Run CI for x86_64-unknown-freebsd target no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants