READY FOR REVIEW/MERGE - Eschew using PNGs in favor of SVGs #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ditch [`unzip`](https://www.npmjs.com/package/unzip) for [`yauzl`](https://www.npmjs.com/package/yauzl) to accommodate Node v12+. (See EvanOxfeld/node-unzip#122, which remains unfixed as of this submission.) Fixes #144. * Don't overwrite icons by different authors with similar names, but instead rename to avoid collisions (`"foo.png"` → `"foo-2.png"`, `"foo-3.png"`, etc.). Fixes #145. * Use `request` to wrap `https`, to properly follow `301`s when fetching the icons library. * Fix `mogrify` argument syntax for more recent versions of ImageMagick (`-channel-fx` → `-fx`). Fixes #119. * Exclude (filter out) non-PNG files from CSS/JS processing. * Update `npm` packages. Probably fixes #107 (but that issue should probably be closed anyway, given its age and lack of detail).
By eliminating the `mogrify` processing dependency, downloading the most recent set of icons goes from hours to well under a minute. SVGs are also superior for scaling on larger cards. A few `.png` files remain, however (namely those not from game-icons.net in `…/classes/…`). Because processing is now so quick, this also removes all icon copies from this repo. This saves a ton of space, but imposes a requirement on cloners to run `node ./resources/tools/update-icons.js` instead of relying on any checked-in snapshot. Fixes #111. Depends on #146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By eliminating the
mogrifyprocessing dependency, downloading the most recent set of icons goes from hours to well under a minute. SVGs are also superior for scaling on larger cards. A few.pngfiles remain, however (namely those not from game-icons.net in…/classes/…).Because processing is now so quick, this also removes all icon copies from this repo. This saves a ton of space, but imposes a requirement on cloners to run
node ./resources/tools/update-icons.jsinstead of relying on any checked-in snapshot.Fixes #111.
Depends on #146.