Replace token query with header attribute #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrulatout
force-pushed
the
token_header
branch
from
4742696 to
e035c09
Compare
mbrulatout
force-pushed
the
token_header
branch
from
e035c09 to
719d428
Compare
mbrulatout
requested review from
dclaisse,
pierrecdn,
cpaillet,
mougams and
manu-ns
pierrecdn
changed the title
pierrecdn
reviewed
Aug 25, 2023
pierrecdn
reviewed
Aug 25, 2023
| self._session = aiohttp.ClientSession(connector=connector, **session_kwargs) | ||
|
|
||
| async def _request(self, callback, method, uri, data=None, connections_timeout=None): | ||
| async def _request(self, callback, method, uri, data=None, connections_timeout=None, **kwargs): |
There was a problem hiding this comment.
shouldn't we explicitly pass and propagate a "headers" argument instead?
kwargs is quite lax, consequently you won't be able to do that for another use-case in the future.
There was a problem hiding this comment.
Nope, it just got lost.
Not sure about the scope of the comment though. Is it line/file specific or global ?
Assuming it's about getting rid of **kwargs everywhere it's been introduced, I'm not a big fan.
I suppose we could keep the **kwargs up to the get/put/post/delete, which would be in charge of building and passing the "headers" arg to _request(...)
See : https://developer.hashicorp.com/consul/api-docs/api-structure The "?token=" query parameter is deprecated and will be removed in Consul 1.17.
mbrulatout
force-pushed
the
token_header
branch
from
719d428 to
fe674b6
Compare
|
rebase only, comments haven't been processed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See : https://developer.hashicorp.com/consul/api-docs/api-structure
The "?token=" query parameter is deprecated and will be removed in Consul 1.17.