Mutualize git clones #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent Chef version, we only use knife
When using multiple cookbooks from a mono-repo, we used to clone the repo multiple times. => Now we clone only once. Also use a single TmpDir for all operations (git clone & policy update) which will be clean at the end. Former code was creating many tmpdir with no explicit clean up.
Annih
force-pushed
the
mutualize_git_clones
branch
from
c2a06db to
4d49268
Compare
jlundqvist-criteo
approved these changes
Jul 25, 2024
Mat-Co
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple cookbooks from a mono-repo, we used to clone the repo multiple times.
=> Now we clone only once.
Also use a single TmpDir for all operations (git clone & policy update) which will be clean at the end. Former code was creating many tmpdir.