Implement configurable OIDC claims extraction #44
Conversation
|
Hi @ErmakovDmitriy - sorry for the delay, we missed this PR. Could you please fix conflicts and push back your patch? Thx |
@ErmakovDmitriy I still see out-of-date branch -> could you please rebase and push? Thx |
\criteo#16 Signed-off-by: Dmitrii Ermakov <[email protected]>
|
Hi @mougams, Thank you for your patience! |
internal/auth/authenticator_oidc.go
Outdated
| return false, []action.Action{BuildRedirectURLMessage(authorizationURL)}, nil | ||
| } | ||
|
|
||
| func (oa *OIDCAuthenticator) builaAuthorizationURL(domain string, oauthArgs OAuthArgs) (string, error) { |
There was a problem hiding this comment.
typo: rename to buildAuthorizationURL
There was a problem hiding this comment.
Thank you for noticing it!
There was a problem hiding this comment.
The tests don't pass, it just hang. Already retriggered twice, same result.
Retrying another time 🤞
There was a problem hiding this comment.
Test passed - I wonder if this is not linked to the HAProxy version - running in the CI, I see version 2.9.9 - and when running locally, I get v2.9.7.
Anyway, not linked to this patch - I'm merging it.
This PR expands the authentication agent with methods to extract an OAuth2 token claims and set
their values to HAProxy session variables.
The token claims are prefixed with "token_claim_" and can be used as in an example below:
#16