http: All http replies should have version set

This fix, make sure all reples will return with a version. Before calling the routes object, the http version is kept and before passing the reply to be sent, the version is set in the object. This fixes the mal-formed http responses that were return on errors. Signed-off-by: Amnon Heiman <[email protected]>
criteo-forks · Oct 27, 2015 · c80c5c0 · c80c5c0
1 parent 9d8913a
commit c80c5c0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/http/httpd.hh b/http/httpd.hh
@@ -351,9 +351,11 @@ public:
                 should_close = true;
             }
             sstring url = set_query_param(*req.get());
+            sstring version = req->_version;
             return _server._routes.handle(url, std::move(req), std::move(resp)).
             // Caller guarantees enough room
-            then([this, should_close](std::unique_ptr<reply> rep) {
+            then([this, should_close, version = std::move(version)](std::unique_ptr<reply> rep) {
+                rep->set_version(version).done();
                 this->_replies.push(std::move(rep));
                 return make_ready_future<bool>(should_close);
             });