Switched generated copy constructor to a dummy one and removed any on… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyril-CdV
force-pushed
the
constructor-and-oneof-simplification
branch
from
f70f2f0 to
e0f99ae
Compare
Cyril-CdV
force-pushed
the
constructor-and-oneof-simplification
branch
from
e0f99ae to
d42ddbe
Compare
fhoering
reviewed
Feb 6, 2025
| * @returns {Codegen} Codegen instance | ||
| */ | ||
| Type.generateConstructor = function generateConstructor(mtype) { | ||
| Type.generateConstructor = function generateConstructor(mtype, minimal = false) { |
There was a problem hiding this comment.
Type.generateConstructor(this) is used in l155 without this flag ?
There was a problem hiding this comment.
My guess is that this call is used to dynamically generate the constructor (i.e. at runtime), only used in the reflection mode (see https://github.com/protobufjs/protobuf.js?tab=readme-ov-file#nodejs)
Cyril-CdV
commented
Feb 7, 2025
Cyril-CdV
force-pushed
the
constructor-and-oneof-simplification
branch
from
a8c7e9a to
51b717c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.