Add retain to IdSlab.
#1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the removal of elements, depending on a predicate, similar to `Vec::retain`.
cristicbz
requested changes
Jan 19, 2018
There was a problem hiding this comment.
Thanks for the PR!
Didn't realise anyone other than me uses this. Could you please add a few tests as well? I'm thinking at least
retainon empty slabretainwhere everything is removed: check old ids don't work anymore and that when some new elements are added they work.- Calling
retaina few times where some things are removed each time; old ids don't work, newly added things do work.
| /// assert!(!id_slab.contains(id3)); | ||
| /// assert!(id_slab.contains(id4)); | ||
| /// ``` | ||
| pub fn retain<F: FnMut(&T) -> bool>(&mut self, mut f: F) { |
There was a problem hiding this comment.
This could take &mut T as argument; you can see the conversation here: https://github.com/Amanieu/rfcs/blob/retain_mut/text/0000-vec-retain_mut.md (in short there's no reason not to do this, it's strictly more general.
|
If you don't mind I can add the commit to do that, I'll leave your commit in anyway for authorship, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the removal of elements, depending on a predicate, similar to
Vec::retain.